add "from" field to rule schema PEOBS-149 #11
Conversation
There was a problem hiding this comment.
Do we need to add more code so that the From rule is preserved and round-tripped correctly?
Based on naming, I have a feeling it will probably be very similar to how we treat To across the provider
https://github.com/Yelp/terraform-provider-cloudhealth/blob/master/cloudhealth/json_to_tf.go#L82
|
I am not entirely confident what this field stands for and whether it holds any significance, all I know is it can trip parsing. I was hoping to follow YAGNI and address the issue at hand, without trying to round-trip it since I don't think it's significant. |
|
It's not blocking us from working on the important perspectives so there is no urgent rush for a partial fix. Understanding what this field does is an important step IMO before we can decide we won't need it. Without support, and it getting added on its own mysteriously, implies we're ok to keep re-applying changes to this resource whenever it reappears, which has been at least twice now IIRC. When I test the provider built from this branch locally, I still get an error, did you see the same thing? I am not sure this is enough of a fix. |
Details and example json are in internal PEOBS-149